Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new workflows with make compile step. #473

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jsfillman
Copy link
Contributor

Summary

This pull request adds new GitHub Actions-based build workflows.
The new workflows are based on our "standard" scripts, located in the /kbase/.github repo, and utilize our new reusable workflows.

Customizations

As part of DEVOPS-765, we've modified the standard workflows to run make compile, which triggers the kb-sdk compile step.

Note that these workflows utilize a custom version of the kbase/kb-sdk image vs the stock ubuntu-latest image. This enables us to us the kb-sdk compile steps in sample_service's Makefile. The custom image is required to make the kb-sdk container successfully run the docker buildx command in our workflows.

Once kb-sdk PR #366 is merged, this custom image can be replaced with the stock kb-sdk image.

Testing

  • A test version of kb-sdk was built using the proposed Dockerfile in kb-sdk PR #366, and pushed to jsfillman/kb-sdk.
  • The reusable workflows were modified to utilize this image and run make compile in the kbase/sdk-compile-test repo, which is a copy of kbase/sample_service.
  • All relevant workflows were tested:
    • ✅ Pull Request Build, Tag, & Push
    • ✅ Build Production Release Image
    • ✅ Manual Build & Push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant